(PDK-513) implement supports_noop
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-513-supports_noop
branch
4 times, most recently
from
7524cc9 to
473674b
Compare
|
requires #32 to pass CI |
DavidS
force-pushed
the
pdk-513-supports_noop
branch
5 times, most recently
from
4eb4cbb to
596ceae
Compare
This is a separate commit of the straight `pdk new provider` output for easier tracking of changes made later.
See https://github.com/DavidS/puppet-specifications/blob/resourceapi/language/resource-api/README.md#provider-feature-supports_noop for a definition of the feature. Since puppet is not calling `flush` for us, this is only a example implementation, that likely will never be exercised.
DavidS
force-pushed
the
pdk-513-supports_noop
branch
from
596ceae to
d171fc6
Compare
da-ar
reviewed
Mar 13, 2018
| end | ||
|
|
||
| it 'respects --noop' do | ||
| pending 'puppet does not call flush() to trigger execution' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/DavidS/puppet-specifications/blob/resourceapi/language/resource-api/README.md#provider-feature-supports_noop for a definition of the feature.
This commit only contains the expected outline of the tests, to structure
what needs to be done.