Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu width issues due to new icons #4502

Closed
jywarren opened this issue Jan 2, 2019 · 6 comments
Closed

Menu width issues due to new icons #4502

jywarren opened this issue Jan 2, 2019 · 6 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet good first issue has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute

Comments

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

I think we need to hide the icon in full width views, so it shows /either/ text or icon - as we're seeing some wrapping issues at certain page widths. Related to #4199 -- thanks! Any help appreciated!

screen shot 2019-01-02 at 1 20 26 pm
@jywarren jywarren added bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Jan 2, 2019
@Chrisyee22
Copy link
Contributor

Hi, could I work on this issue??

@grvsachdeva
Copy link
Member

Hi @Chrisyee22, please go ahead!

@jywarren jywarren mentioned this issue Jan 2, 2019
Closed
5 tasks
@Chrisyee22 Chrisyee22 mentioned this issue Jan 4, 2019
Closed
5 tasks
@Chrisyee22
Copy link
Contributor

Here's a link to a gif. Does this work?
https://media.giphy.com/media/2dcW4fQOKFn3JMDKcy/source.mp4

Closed
@grvsachdeva grvsachdeva added the has-pull-request issues which already have a pull request solving it label Jan 21, 2019
@jywarren jywarren mentioned this issue Jan 22, 2019
Closed
@IshaGupta18
Copy link
Collaborator

@Chrisyee22 we can resolve this together, you can refer to #4690 for some more information. I would love to work with you. Thanks a lot!

@d5nguyen
Copy link

hello there! I'm unsure if this issue has been resolved yet or not. Please let me know as I'd love to work on this if it has become available :)

@jywarren
Copy link
Member Author

I believe it's been resolved as we have minimized the changes to the header, and frozen the design until the Bootstrap 4 upgrade -- we'd love your help on other design upgrades though! #4922 #5090 ! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet good first issue has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jywarren @grvsachdeva @Chrisyee22 @d5nguyen @oorjitchowdhary @IshaGupta18