Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crontab jobs for sending trending Topics to Users #2091

Closed
namangupta01 opened this issue Jan 24, 2018 · 3 comments
Closed

Crontab jobs for sending trending Topics to Users #2091

namangupta01 opened this issue Jan 24, 2018 · 3 comments
Assignees
@namangupta01
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features feature explains that the issue is to add a new feature
Milestone
Email notificatio...

Comments

@namangupta01
Copy link
Member

namangupta01 commented Jan 24, 2018 •
edited
Loading

Please describe the problem (or idea)

We can use crontab jobs to send mails to users about trending topics and for the other stuff just like we got mail from twitter about treading topics or about people. I think it would would be great if users get to know about the trending topics on mail. What do you say @jywarren @icarito @ryzokuken ?

Timing of sending of the mail can be pre set so that we know when we are going to get the mail.
@namangupta01 namangupta01 added enhancement explains that the issue is to improve upon one of our existing features feature explains that the issue is to add a new feature labels Jan 24, 2018
@namangupta01 namangupta01 self-assigned this Jan 24, 2018
@jywarren jywarren added this to the Email notifications overhaul milestone Jan 25, 2018
@jywarren
Copy link
Member

jywarren commented Jan 25, 2018 •
edited
Loading

Hi, I like this idea a lot -- we're actually working on a related set of issues in #2104, and to do this kind of thing we first need a kind of "digest" of followed content, which is the subject of #1119 and more recently #2027.

After that, we're going to try to send this digest each day by email in #1584

We could definitely use your help with some of these! I wonder if you could start working based on #2027 but developing an email template that can be triggered in the SubscriptionMailer that would send the digest!

We could rename this issue Develop email template and mailer for followed content digests and -- even without ActiveJob (cron) triggers, we can start testing this feature by putting a button on /subscriptions that says email me the past week's followed content

This way we can test this out on production a bit without worrying about sending a million emails by mistake :-P

We'd LOVE your help with this! 👍

@jywarren
Copy link
Member

I also LOVE that you thought of this in parallel! To me, that means it's a really good idea!

@ebarry ebarry mentioned this issue Jan 25, 2018
Closed
29 tasks
@namangupta01 namangupta01 added the break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration label Jan 30, 2018
@jywarren
Copy link
Member

jywarren commented May 3, 2018

I think this can be merged into #2104 now! Please chime in if there's anything missing over there though!

@jywarren jywarren closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namangupta01 namangupta01

Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features feature explains that the issue is to add a new feature
Projects
None yet
Milestone
Email notifications overhaul
Development

No branches or pull requests
2 participants
@jywarren @namangupta01