-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass lazy loading for blob images (infragram uploads) #10210
Comments
Noting this type of image does display in the Wayback machine: and you can see that it actually has the filename "blob" - but seems to be stored like a normal file:
So the problem may be that it's actually just a JPG but it has the name "blob" instead of, say, "blob.jpg" |
Yes, AND, https://storage.googleapis.com/publiclab-production/public/system/images/photos/000/044/103/original/blob actually works -- just not the other sizes! So we should be able to filter for filename "blob" and just only display the original size. |
OK, tried that conditional on both note show pages and card display. I guess we should do wiki pages too... hang on... |
We have a category of images which are saved as "blobs" forwarded from another website of ours, https://infragram.org - and this breaks our "lazy loading" optimization of images. Let's just turn off lazy loading for this "card" display and it should resolve, although we could later introduce a conditional to detect this type of image.
https://publiclab.org/tag/infragram-upload
#8043 (comment)
The code segment to revert is here:
https://github.com/publiclab/plots2/pull/8043/files/ab08fe9efa1723f4980e471d68081f05524fa49e#diff-ec08e67cfb3992bd8df01f2904b6dd82680df1e272a7d1d9a941900db40f409eL3
Really just the entire
app/views/notes/_card.html.erb
file.The text was updated successfully, but these errors were encountered: