New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better result checking for accept lending code request #555

Closed

banukutlu opened this issue Dec 7, 2022 · 0 comments · Fixed by #569

Assignees

Milestone

Contributor

banukutlu commented Dec 7, 2022

Currently we are not checking if the request successful or not and redirecting to thank you page regardless.
We should check the response code and redirect accordingly here https://github.com/psu-libraries/myaccount/blob/main/app/controllers/lending_policy_controller.rb#L9

banukutlu added this to the 1.2.x milestone

Smullz622 self-assigned this

Smullz622 mentioned this issue

accept lending policy error checking #562

Closed

Smullz622 linked a pull request

that will close this issue

accept lending policy error checking #562

Closed

Smullz622 mentioned this issue

Accept lending policy #569

Merged

banukutlu closed this as completed in #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment