holds/new form throws an error when record has no holdables items

[banukutlu]

try /holds/new?catkey=19200019

[banukutlu]

some notes from debugging this record:

currentLocations on this catkey are CHECKEDOUT, STACKS-BD, STACKS-HB3
CHECKEDOUT not holdable anyway
STACKS-BD, STACKS-HB3 are not returning back from find_holdable_locations even though this catkey has IWantIt and availability returns holdable

locations returned from policy call includes these locations as not holdable
"fields"=>{"displayName"=>"STACKS-HB3", "holdable"=>false}
"fields"=>{"displayName"=>"STACKS-BD", "holdable"=>false}
so result of that is no holdable items.

We should probably catch this case rather than 500
but also interesting that these locations comes back as not holdable, so is the record holdable or not?

[banukutlu]

Update: these locations were updated as holdable but cache needed to be cleared and server needed to be restarted on the sirsi side, after Maryam doing that, now those two locations shows up holdable.

Also, added a fix for it to not error out in this case.

[cdmo]

I'm going to reopen this because I don't think it passed. Please correct me if I'm wrong.

[ruthtillman]

I QAd this one. I got the item itself to work successfully but when attempting other items which shouldn't be put on hold at all (just as an edge case), it didn't do anything. Should redirect to my acct home I believe.

[cdmo]

Ok cool. Just wasn't sure. Thanks.

[banukutlu]

reopened to add a message Sorry! You cannot place a hold on this item. Contact your library if you need assistance for records that are not holdable eg. catkey: 31200756

[ruthtillman]

Tested with both online item and item which doesn't exist. Successful!