Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to override explicit proptest_config from env vars #315

Closed
tzemanovic opened this issue Apr 16, 2023 · 0 comments · Fixed by #318
Closed

allow to override explicit proptest_config from env vars #315

tzemanovic opened this issue Apr 16, 2023 · 0 comments · Fixed by #318

Comments

@tzemanovic
Copy link
Contributor

tzemanovic commented Apr 16, 2023

When the explicit #[proptest_config(Config ...)] is being used in a test, for any fields that are not Config::default() the PROPTEST_ env vars are ignored. I think it would be better to allow the env vars to override the config as it enables ad hoc changes without recompiling, but it is potentially a breaking change if someone relies on the current behavior.

The fix should be easy to do using fn contextualize_config from mod config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant