Skip to content

Commit d216b3f

Browse files
committed
fix flaky JettyStatisticsCollectorTest
1 parent b76e1e9 commit d216b3f

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.circleci/config.yml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ jobs:
99
- checkout
1010
- restore_cache:
1111
key: maven-dependencies-{{ checksum "pom.xml" }}
12+
- run: java -version
1213
- run: ./mvnw clean verify
1314
- save_cache:
1415
paths:

simpleclient_jetty/src/test/java/io/prometheus/client/jetty/JettyStatisticsCollectorTest.java

+9-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,15 @@ public void collect() throws Exception {
6161
}
6262

6363
assertThat(CollectorRegistry.defaultRegistry.getSampleValue("jetty_requests_total"), is(1.0));
64-
assertThat(CollectorRegistry.defaultRegistry.getSampleValue("jetty_requests_active"), is(0.0));
64+
Double jettyRequestsActive = null;
65+
for (int i=0; i<10; i++) {
66+
jettyRequestsActive = CollectorRegistry.defaultRegistry.getSampleValue("jetty_requests_active");
67+
if (Double.valueOf(0.0).equals(jettyRequestsActive)) {
68+
break;
69+
}
70+
Thread.sleep(50);
71+
}
72+
assertThat(jettyRequestsActive, is(0.0));
6573
assertThat(CollectorRegistry.defaultRegistry.getSampleValue("jetty_requests_active_max"),
6674
is(1.0));
6775
assertThat(CollectorRegistry.defaultRegistry.getSampleValue("jetty_request_time_max_seconds"),

0 commit comments

Comments
 (0)