Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.7, 3.5 support, add 3.6-3.9 for fluent.syntax #161

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Feb 24, 2021

This is pretty mechanic, doing Syntax first, as fluent.runtime and fluent.pygments depend on released versions of fluent.syntax.

  • Update metadata and testing matrix
  • Drop six
  • pyupgrade --py36-plus
  • Version bump and release notes

pyupgrade comes from https://github.com/asottile/pyupgrade.

I did try --py39-plus just for the kicks of it, and that didn't show anything more.

@Pike
Copy link
Contributor Author

Pike commented Feb 24, 2021

@zbraniecki , this looks good for review to me now. r?

First phase of #162, not adding any closing keywords on this one.

Copy link
Collaborator

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Pike
Copy link
Contributor Author

Pike commented Mar 2, 2021

Thanks for the review.
I have no permissions on this repo, can you merge this?

@zbraniecki
Copy link
Collaborator

I have no permissions on this repo

That's fixed now.

@zbraniecki zbraniecki merged commit 7e1c4be into projectfluent:master Mar 2, 2021
@Pike Pike deleted the drop-old-python-syntax branch March 8, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants