Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fluent.syntax) Don't drop to newline when serializing patterns starting with special chars #156

Merged
merged 1 commit into from
Aug 27, 2020
Merged

(fluent.syntax) Don't drop to newline when serializing patterns starting with special chars #156

merged 1 commit into from
Aug 27, 2020

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Aug 27, 2020

@stasm stasm force-pushed the fix-special-chars-infront branch from ec9340b to 2774242 Compare August 27, 2020 12:12
Pike
Pike approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the port.

Things I checked for in differences to JS: elements[0]´ would behave different in js and python, but is guarded by any([])` being false.

Different number of files is due to the abscense of a runtime parser in python.

@stasm stasm merged commit b41a014 into projectfluent:master Aug 27, 2020
@stasm stasm deleted the fix-special-chars-infront branch August 27, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @Pike