Create test case to prevent nested selectors #279

Pike · 2019-08-03T08:44:06Z

We should audit the test coverage for

Lines 54 to 61 in 94dae4d

    
           return ([selector, variants]) => { 
        
               let selector_is_valid = 
        
                   selector instanceof FTL.StringLiteral 
        
                   || selector instanceof FTL.NumberLiteral 
        
                   || selector instanceof FTL.VariableReference 
        
                   || selector instanceof FTL.FunctionReference 
        
                   || (selector instanceof FTL.TermReference 
        
                       && selector.attribute);

Notably, I don't think we have a test to check for select expressions as selectors.

AFAICT, this also bleeds into our implementations.

…tfluent#279 There were no tests for the full set of forbidden selector expressions. That made it possible to pass the existing test suite while adding `FTL.Placeable` to the list of allowed grammar productions in `abstract.js`. The test coverage is split between `select_expressions.ftl`, and `reference_expressions.ftl`.

Pike mentioned this issue Aug 3, 2019

SelectExpression as a selector for another SelectExpression projectfluent/fluent.js#416

Closed

Pike closed this as completed in 70e305a Aug 5, 2019

This was referenced Aug 5, 2019

Uplift nested selector tests projectfluent/python-fluent#122

Closed

Uplift nested selector tests projectfluent/fluent-rs#133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create test case to prevent nested selectors #279

Create test case to prevent nested selectors #279

Pike commented Aug 3, 2019

Create test case to prevent nested selectors #279

Create test case to prevent nested selectors #279

Comments

Pike commented Aug 3, 2019