Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@fluent/syntax: Don't drop to newline when serializing patterns starting with special chars #513

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Aug 10, 2020

Fix #512.

@stasm stasm force-pushed the fix-special-chars-start branch from 4c39b50 to 599c482 Compare August 10, 2020 16:37
@stasm stasm requested a review from Pike August 10, 2020 16:41
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks right and the tests, too.

Just some refactoring/renaming, as I expected the fix to look differently from reading it.

@stasm stasm requested a review from Pike August 11, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@fluent/syntax: Variant values with [] don't roundtrip through the parser/serializer
2 participants