Skip to content

Commit d95e522

Browse files
authored
replace all logrus to internal log (#436)
1 parent cd25874 commit d95e522

File tree

6 files changed

+27
-26
lines changed

6 files changed

+27
-26
lines changed

client/interceptor/retry.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"strings"
66

77
"github.com/cenkalti/backoff/v4"
8-
log "github.com/sirupsen/logrus"
8+
"github.com/projecteru2/core/log"
99

1010
"google.golang.org/grpc"
1111
)
@@ -32,7 +32,7 @@ func NewStreamRetry(retryOpts RetryOptions) grpc.StreamClientInterceptor {
3232
if _, ok := RPCNeedRetry[method]; !ok {
3333
return stream, err
3434
}
35-
log.Debugf("[NewStreamRetry] return retryStreawm for method %s", method)
35+
log.Debugf(ctx, "[NewStreamRetry] return retryStreawm for method %s", method)
3636
return &retryStream{
3737
ctx: ctx,
3838
ClientStream: stream,
@@ -57,7 +57,7 @@ func (s *retryStream) RecvMsg(m interface{}) (err error) {
5757
}
5858

5959
return backoff.Retry(func() error {
60-
log.Debug("[retryStream] retry on new stream")
60+
log.Debug(context.TODO(), "[retryStream] retry on new stream")
6161
stream, err := s.newStream()
6262
if err != nil {
6363
// even io.EOF triggers retry, and it's what we want!

client/resolver/eru/resolver.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"strings"
66

77
"github.com/projecteru2/core/client/servicediscovery"
8-
log "github.com/sirupsen/logrus"
8+
"github.com/projecteru2/core/log"
99

1010
"github.com/projecteru2/core/types"
1111
"google.golang.org/grpc/resolver"
@@ -44,20 +44,20 @@ func (r *Resolver) Close() {
4444
}
4545

4646
func (r *Resolver) sync() {
47-
log.Debug("[EruResolver] start sync service discovery")
47+
log.Debug(context.TODO(), "[EruResolver] start sync service discovery")
4848
ctx, cancel := context.WithCancel(context.Background())
4949
r.cancel = cancel
5050
defer cancel()
5151

5252
ch, err := r.discovery.Watch(ctx)
5353
if err != nil {
54-
log.Errorf("[EruResolver] failed to watch service status: %v", err)
54+
log.Errorf(ctx, "[EruResolver] failed to watch service status: %v", err)
5555
return
5656
}
5757
for {
5858
select {
5959
case <-ctx.Done():
60-
log.Errorf("[EruResolver] watch interrupted: %v", ctx.Err())
60+
log.Errorf(ctx, "[EruResolver] watch interrupted: %v", ctx.Err())
6161
return
6262
case endpoints, ok := <-ch:
6363
if !ok {

client/servicediscovery/eru_service_discovery.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"github.com/projecteru2/core/auth"
1010
"github.com/projecteru2/core/client/interceptor"
1111
"github.com/projecteru2/core/client/utils"
12-
log "github.com/sirupsen/logrus"
12+
"github.com/projecteru2/core/log"
1313

1414
pb "github.com/projecteru2/core/rpc/gen"
1515
"github.com/projecteru2/core/types"
@@ -34,7 +34,7 @@ func New(endpoint string, authConfig types.AuthConfig) *EruServiceDiscovery {
3434
func (w *EruServiceDiscovery) Watch(ctx context.Context) (_ <-chan []string, err error) {
3535
cc, err := w.dial(ctx, w.endpoint, w.authConfig)
3636
if err != nil {
37-
log.Errorf("[EruServiceWatch] dial failed: %v", err)
37+
log.Errorf(ctx, "[EruServiceWatch] dial failed: %v", err)
3838
return
3939
}
4040
client := pb.NewCoreRPCClient(cc)
@@ -48,7 +48,7 @@ func (w *EruServiceDiscovery) Watch(ctx context.Context) (_ <-chan []string, err
4848
watchCtx, cancelWatch := context.WithCancel(ctx)
4949
stream, err := client.WatchServiceStatus(watchCtx, &pb.Empty{})
5050
if err != nil {
51-
log.Errorf("[EruServiceWatch] watch failed, try later: %v", err)
51+
log.Errorf(ctx, "[EruServiceWatch] watch failed, try later: %v", err)
5252
time.Sleep(10 * time.Second)
5353
continue
5454
}
@@ -69,7 +69,7 @@ func (w *EruServiceDiscovery) Watch(ctx context.Context) (_ <-chan []string, err
6969
status, err := stream.Recv()
7070
close(cancelTimer)
7171
if err != nil {
72-
log.Errorf("[EruServiceWatch] recv failed: %v", err)
72+
log.Errorf(ctx, "[EruServiceWatch] recv failed: %v", err)
7373
break
7474
}
7575
expectedInterval = time.Duration(status.GetIntervalInSecond())

client/utils/servicepusher.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"time"
99

1010
"github.com/go-ping/ping"
11-
log "github.com/sirupsen/logrus"
11+
"github.com/projecteru2/core/log"
1212
)
1313

1414
// EndpointPusher pushes endpoints to registered channels if the ep is L3 reachable
@@ -53,7 +53,7 @@ func (p *EndpointPusher) delOutdated(endpoints []string) {
5353
if _, ok := newEps[ep]; !ok {
5454
cancel()
5555
p.pendingEndpoints.Delete(ep)
56-
log.Debugf("[EruResolver] pending endpoint deleted: %s", ep)
56+
log.Debugf(context.TODO(), "[EruResolver] pending endpoint deleted: %s", ep)
5757
}
5858
return true
5959
})
@@ -66,7 +66,7 @@ func (p *EndpointPusher) delOutdated(endpoints []string) {
6666
}
6767
if _, ok := newEps[ep]; !ok {
6868
p.availableEndpoints.Delete(ep)
69-
log.Debugf("[EruResolver] available endpoint deleted: %s", ep)
69+
log.Debugf(context.TODO(), "[EruResolver] available endpoint deleted: %s", ep)
7070
}
7171
return true
7272
})
@@ -84,20 +84,20 @@ func (p *EndpointPusher) addCheck(endpoints []string) {
8484
ctx, cancel := context.WithCancel(context.Background())
8585
p.pendingEndpoints.Store(endpoint, cancel)
8686
go p.pollReachability(ctx, endpoint)
87-
log.Debugf("[EruResolver] pending endpoint added: %s", endpoint)
87+
log.Debugf(ctx, "[EruResolver] pending endpoint added: %s", endpoint)
8888
}
8989
}
9090
func (p *EndpointPusher) pollReachability(ctx context.Context, endpoint string) {
9191
parts := strings.Split(endpoint, ":")
9292
if len(parts) != 2 {
93-
log.Errorf("[EruResolver] wrong format of endpoint: %s", endpoint)
93+
log.Errorf(context.TODO(), "[EruResolver] wrong format of endpoint: %s", endpoint)
9494
return
9595
}
9696

9797
for {
9898
select {
9999
case <-ctx.Done():
100-
log.Debugf("[EruResolver] reachability goroutine ends: %s", endpoint)
100+
log.Debugf(ctx, "[EruResolver] reachability goroutine ends: %s", endpoint)
101101
return
102102
default:
103103
}
@@ -110,15 +110,15 @@ func (p *EndpointPusher) pollReachability(ctx context.Context, endpoint string)
110110
p.pendingEndpoints.Delete(endpoint)
111111
p.availableEndpoints.Store(endpoint, struct{}{})
112112
p.pushEndpoints()
113-
log.Debugf("[EruResolver] available endpoint added: %s", endpoint)
113+
log.Debugf(ctx, "[EruResolver] available endpoint added: %s", endpoint)
114114
return
115115
}
116116
}
117117

118118
func (p *EndpointPusher) checkReachability(host string) (err error) {
119119
pinger, err := ping.NewPinger(host)
120120
if err != nil {
121-
log.Errorf("[EruResolver] failed to create pinger: %+v", err)
121+
log.Errorf(context.TODO(), "[EruResolver] failed to create pinger: %+v", err)
122122
return
123123
}
124124
defer pinger.Stop()

log/log.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ func Infof(ctx context.Context, format string, args ...interface{}) {
107107

108108
// Debug is Debug
109109
func Debug(ctx context.Context, args ...interface{}) {
110-
a := []interface{}{}
111-
a = append(a, interface{}(getTracingInfo(ctx)))
112-
log.Debug(append(a, args...))
110+
a := []interface{}{getTracingInfo(ctx)}
111+
a = append(a, args...)
112+
log.Debug(a)
113113
}
114114

115115
// Debugf is Debugf

wal/hydro.go

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package wal
22

33
import (
4+
"context"
45
"encoding/json"
56
"sync"
67
"time"
78

8-
log "github.com/sirupsen/logrus"
9+
"github.com/projecteru2/core/log"
910

1011
coretypes "github.com/projecteru2/core/types"
1112
"github.com/projecteru2/core/wal/kv"
@@ -48,7 +49,7 @@ func (h *Hydro) Recover() {
4849
for ent := range ch {
4950
ev, err := h.decodeEvent(ent)
5051
if err != nil {
51-
log.Errorf("[Recover] decode event error: %v", err)
52+
log.Errorf(context.TODO(), "[Recover] decode event error: %v", err)
5253
continue
5354
}
5455
events = append(events, ev)
@@ -57,12 +58,12 @@ func (h *Hydro) Recover() {
5758
for _, ev := range events {
5859
handler, ok := h.getEventHandler(ev.Type)
5960
if !ok {
60-
log.Errorf("[Recover] no such event handler for %s", ev.Type)
61+
log.Errorf(context.TODO(), "[Recover] no such event handler for %s", ev.Type)
6162
continue
6263
}
6364

6465
if err := h.recover(handler, ev); err != nil {
65-
log.Errorf("[Recover] handle event %d (%s) failed: %v", ev.ID, ev.Type, err)
66+
log.Errorf(context.TODO(), "[Recover] handle event %d (%s) failed: %v", ev.ID, ev.Type, err)
6667
continue
6768
}
6869
}

0 commit comments

Comments
 (0)