Skip to content

Commit a0b6f3a

Browse files
authored
fix the bugs of 'make test' and 'getFullResult' (#503)
1 parent 7513bc0 commit a0b6f3a

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ cloc:
4646
cloc --exclude-dir=vendor,3rdmocks,mocks,tools,gen --not-match-f=test .
4747

4848
unit-test:
49-
go vet `go list ./... | grep -v '/vendor/' | grep -v '/tools'`
49+
go vet `go list ./... | grep -v '/vendor/' | grep -v '/tools'` && \
5050
go test -race -timeout 240s -count=1 -cover ./utils/... \
5151
./types/... \
5252
./store/etcdv3/. \
@@ -66,7 +66,7 @@ unit-test:
6666
./wal/. \
6767
./wal/kv/. \
6868
./store/redis/... \
69-
./lock/redis/...
69+
./lock/redis/... && \
7070
go test -timeout 240s -count=1 -cover ./cluster/calcium/...
7171

7272
lint:

scheduler/complex/resource.go

+16-6
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,23 @@ func (h *host) getFragmentsResult(resources []resourceInfo, fragments ...int64)
184184
func (h *host) getFullResult(full int, resources []resourceInfo) []types.ResourceMap {
185185
result := []types.ResourceMap{}
186186

187-
count := len(resources) / full
188-
for i := 0; i < count; i++ {
189-
plan := types.ResourceMap{}
190-
for j := i * full; j < i*full+full; j++ {
191-
plan[resources[j].id] = int64(h.share)
187+
for len(resources)/full > 0 {
188+
count, rem := len(resources)/full, len(resources)%full
189+
newResources := []resourceInfo{}
190+
for i := 0; i < count; i++ {
191+
plan := types.ResourceMap{}
192+
for j := i * full; j < i*full+full; j++ {
193+
// 洗掉没配额的
194+
last := resources[j].pieces - int64(h.share)
195+
if last > 0 {
196+
newResources = append(newResources, resourceInfo{resources[j].id, last})
197+
}
198+
plan[resources[j].id] = int64(h.share)
199+
}
200+
result = append(result, plan)
192201
}
193-
result = append(result, plan)
202+
203+
resources = append(newResources, resources[len(resources)-rem:]...)
194204
}
195205

196206
return result

0 commit comments

Comments
 (0)