Skip to content

Commit 7789588

Browse files
committed
Merge branch 'bug/build' into 'master'
fix build error See merge request !68
2 parents 35f1046 + 9c19b9f commit 7789588

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

cluster/calcium/build_image.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ func getRandomNode(c *calcium, podname string) (*types.Node, error) {
7272
return nil, err
7373
}
7474
if len(nodes) == 0 {
75-
return nil, fmt.Errorf("No nodes available in pod %s", podname)
75+
err = fmt.Errorf("No nodes available in pod %s", podname)
76+
log.Debugf("Error during getRandomNode from %s: %v", podname, err)
77+
return nil, err
7678
}
7779

7880
nodemap := make(map[string]types.CPUMap)
@@ -81,6 +83,11 @@ func getRandomNode(c *calcium, podname string) (*types.Node, error) {
8183
}
8284
nodename, err := c.scheduler.RandomNode(nodemap)
8385
if err != nil {
86+
log.Debugf("Error during getRandomNode from %s: %v", podname, err)
87+
return nil, err
88+
}
89+
if nodename == "" {
90+
err = fmt.Errorf("Got empty node during getRandomNode from %s", podname)
8491
return nil, err
8592
}
8693

cluster/calcium/meta.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ package calcium
33
// All functions are just proxy to store, since I don't want store to be exported.
44
// All these functions are meta data related.
55

6-
import "gitlab.ricebook.net/platform/core/types"
6+
import (
7+
log "github.com/Sirupsen/logrus"
8+
"gitlab.ricebook.net/platform/core/types"
9+
)
710

811
func (c *calcium) ListPods() ([]*types.Pod, error) {
912
return c.store.GetAllPods()
@@ -50,14 +53,15 @@ func (c *calcium) ListPodNodes(podname string, all bool) ([]*types.Node, error)
5053
var nodes []*types.Node
5154
candidates, err := c.store.GetNodesByPod(podname)
5255
if err != nil {
56+
log.Debugf("Error during ListPodNodes from %s: %v", podname, err)
5357
return nodes, err
5458
}
5559
for _, candidate := range candidates {
5660
if candidate.Available || all {
5761
nodes = append(nodes, candidate)
5862
}
5963
}
60-
return nodes, err
64+
return nodes, nil
6165
}
6266

6367
func (c *calcium) GetContainer(id string) (*types.Container, error) {

0 commit comments

Comments
 (0)