Skip to content

Commit 538db3e

Browse files
committed
Merge branch 'refactor/image' into 'master'
it's ok not to remove image while removing container See merge request !65
2 parents 3104fc1 + f524dcb commit 538db3e

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.7.21
1+
0.7.22

cluster/calcium/helper.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func makeMountPaths(specs types.Specs, config types.Config) ([]string, map[strin
140140
func runExec(client *engineapi.Client, container enginetypes.ContainerJSON, label string) error {
141141
cmd, ok := container.Config.Labels[label]
142142
if !ok || cmd == "" {
143-
log.Debug("No %q found in container %q", label, container.ID)
143+
log.Debug("No %s found in container %s", label, container.ID)
144144
return nil
145145
}
146146

cluster/calcium/remove_container.go

-10
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,5 @@ func (c *calcium) removeOneContainer(container *types.Container) error {
123123
log.Errorf("Error during ContainerRemove: %s", err.Error())
124124
return err
125125
}
126-
127-
// try to remove corresponding image
128-
// we don't care if some container is still using the image
129-
// docker will care that for us
130-
// TODO what if we use another worker to clean all the images?
131-
rmiOpts := enginetypes.ImageRemoveOptions{
132-
Force: false,
133-
PruneChildren: true,
134-
}
135-
go container.Engine.ImageRemove(context.Background(), info.Image, rmiOpts)
136126
return nil
137127
}

0 commit comments

Comments
 (0)