fix a known issue in SetNode

Author: DuodenumL

cluster/calcium/node.go

@@ -77,7 +77,7 @@ func (c *Calcium) SetNode(ctx context.Context, opts *types.SetNodeOptions) (*typ
 			err := c.store.SetNodeStatus(ctx, node, -1)
 			if err != nil {
 				// don't return here
-				log.Errorf(ctx, "[SetNode] failed to set node status, err: %v", err)
+				log.Errorf(ctx, "[SetNode] failed to set node status, err: %+v", errors.WithStack(err))
 			}
 		}
 		if opts.WorkloadsDown {
@@ -154,15 +154,17 @@ func (c *Calcium) SetNode(ctx context.Context, opts *types.SetNodeOptions) (*typ
 			case !ok && cpuShare > 0: // incr CPU
 				n.CPU[cpuID] = cpuShare
 				n.InitCPU[cpuID] = cpuShare
-			case ok && cpuShare == 0: // decr CPU
-				delete(n.CPU, cpuID)
-				delete(n.InitCPU, cpuID)
 			case ok: // decr share
 				n.CPU[cpuID] += cpuShare
 				n.InitCPU[cpuID] += cpuShare
 				if n.CPU[cpuID] < 0 {
 					return logger.Err(ctx, errors.WithStack(types.ErrBadCPU))
 				}
+				if n.InitCPU[cpuID] == 0 {
+					// decr CPU
+					delete(n.CPU, cpuID)
+					delete(n.InitCPU, cpuID)
+				}
 			}
 		}
 		// update volume

cluster/calcium/node_test.go

@@ -250,9 +250,9 @@ func TestSetNode(t *testing.T) {
 	n, err = c.SetNode(ctx, setOpts)
 	assert.Error(t, err)
 	// succ set cpu, add and del
-	n.CPU = types.CPUMap{"1": 1, "2": 2}
+	n.CPU = types.CPUMap{"1": 10, "2": 2}
 	n.InitCPU = types.CPUMap{"1": 10, "2": 10}
-	setOpts.DeltaCPU = types.CPUMap{"1": 0, "2": -1, "3": 10}
+	setOpts.DeltaCPU = types.CPUMap{"1": -10, "2": -1, "3": 10}
 	n, err = c.SetNode(ctx, setOpts)
 	assert.NoError(t, err)
 	_, ok := n.CPU["1"]