minor refactor createworkloadhandler

Author: CMGS

cluster/calcium/remove.go

@@ -45,7 +45,7 @@ func (c *Calcium) RemoveWorkload(ctx context.Context, ids []string, force bool)
 									},
 									// then
 									func(ctx context.Context) (err error) {
-										if err = c.doRemoveWorkload(ctx, workload, force); err != nil {
+										if err = c.doRemoveWorkload(ctx, workload, force); err == nil {
 											log.Infof(ctx, "[RemoveWorkload] Workload %s removed", workload.ID)
 										}
 										return err
@@ -110,6 +110,7 @@ func (c *Calcium) doRemoveWorkloadSync(ctx context.Context, ids []string) error
 	}
 
 	for m := range ch {
+		// TODO deal with failed
 		log.Debugf(ctx, "[doRemoveWorkloadSync] Removed %s", m.WorkloadID)
 	}
 	return nil

cluster/calcium/wal.go

@@ -169,17 +169,9 @@ func (h *CreateWorkloadHandler) Handle(ctx context.Context, raw interface{}) (er
 	defer cancel()
 
 	if _, err = h.calcium.GetWorkload(ctx, wrk.ID); err == nil {
-		// workload meta exists
-		ch, err := h.calcium.RemoveWorkload(ctx, []string{wrk.ID}, true)
-		if err != nil {
-			return logger.Err(ctx, err)
-		}
-		for msg := range ch {
-			if !msg.Success {
-				logger.Errorf(ctx, "failed to remove workload")
-			}
+		if err = h.calcium.doRemoveWorkloadSync(ctx, []string{wrk.ID}); err != nil {
+			return err
 		}
-		logger.Infof(ctx, "workload with meta removed")
 		return nil
 	}