ensure features compatible with old version

Author: jschwinger233

cluster/calcium/send.go

@@ -49,6 +49,6 @@ func (c *Calcium) Send(ctx context.Context, opts *types.SendOptions) (chan *type
 }
 
 func (c *Calcium) doSendFileToWorkload(ctx context.Context, engine engine.API, ID string, file types.LinuxFile) error {
-	log.Infof(ctx, "[doSendFileToWorkload] Send file to %s:%s", ID)
+	log.Infof(ctx, "[doSendFileToWorkload] Send file to %s:%s", ID, file.Filename)
 	return errors.WithStack(engine.VirtualizationCopyTo(ctx, ID, file.Filename, file.Clone().Content, file.UID, file.GID, file.Mode))
 }

engine/docker/tarfile.go

@@ -39,9 +39,9 @@ func tempTarFile(path string, data []byte, uid, gid int, mode int64) (string, er
 	hdr := &tar.Header{
 		Name: filename,
 		Size: int64(len(data)),
-		Mode: int64(mode),
-		Uid:  int(uid),
-		Gid:  int(gid),
+		Mode: mode,
+		Uid:  uid,
+		Gid:  gid,
 	}
 	if err := tw.WriteHeader(hdr); err != nil {
 		return name, err

rpc/rpc.go

@@ -471,8 +471,8 @@ func (v *Vibranium) Copy(opts *pb.CopyOptions, stream pb.CoreRPC_CopyServer) err
 				defer tw.Close()
 				header := &tar.Header{
 					Name: filepath.Base(m.Filename),
-					Uid:  int(m.UID),
-					Gid:  int(m.GID),
+					Uid:  m.UID,
+					Gid:  m.GID,
 					Mode: m.Mode,
 					Size: int64(len(m.Content)),
 				}

rpc/transform.go

@@ -291,13 +291,17 @@ func toCoreDeployOptions(d *pb.DeployOptions) (*types.DeployOptions, error) {
 	var err error
 	files := []types.LinuxFile{}
 	for filename, bs := range d.Data {
-		files = append(files, types.LinuxFile{
+		file := types.LinuxFile{
 			Content:  bs,
 			Filename: filename,
 			UID:      int(d.Owners[filename].GetUid()),
 			GID:      int(d.Owners[filename].GetGid()),
 			Mode:     d.Modes[filename].GetMode(),
-		})
+		}
+		if file.Mode == 0 && file.UID == 0 && file.GID == 0 {
+			file.Mode = 0755
+		}
+		files = append(files, file)
 	}
 
 	vbsLimit, err := types.NewVolumeBindings(d.ResourceOpts.VolumesLimit)

types/options.go

@@ -116,6 +116,12 @@ func (o *SendOptions) Validate() error {
 	if len(o.Files) == 0 {
 		return errors.WithStack(ErrNoFilesToSend)
 	}
+	for i, file := range o.Files {
+		if file.UID == 0 && file.GID == 0 && file.Mode == 0 {
+			// we see it as requiring "default perm"
+			o.Files[i].Mode = 0755
+		}
+	}
 	return nil
 }