Add description to heading block widget #3442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
3434-heading-description
branch
from
2f4811c to
823ab48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3434
I'm not sure how I feel about this. It's probably fine as a stopgap.
The heading block template can be overridden by the host app making this inaccurate unless they also remember to update this description.
Sir Trevor supports multiple heading levels in the default config via:
We'd need to start using that level data attribute in the template to select the tag.
It does use scribe for determining the levels automatically which seems to be non-functional, at least in Spotlight, and defunct: https://github.com/guardian/scribe
If we accept this and continue to use Sir Trevor for any length of time, I think we should make a new issue to create a view component for the heading block and either allow the user to select the heading level or have our own automatic scheme. Either may require design.