Skip to content

Commit a6dd083

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Disable the shared-reviwers-signify group for now. (#25627)
Due to dropseed/pullapprove#71 it's causing PRs to land with an insufficient number of reviews.
1 parent 0518993 commit a6dd083

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

.pullapprove.yml

+14-8
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,20 @@ groups:
144144
teams: [reviewers-samsung]
145145
reviews:
146146
request: 10
147-
shared-reviewers-signify:
148-
type: optional
149-
conditions:
150-
- files.include('*')
151-
reviewers:
152-
teams: [reviewers-signify]
153-
reviews:
154-
request: 10
147+
# shared-reviewers-signify disabled for now, because the reviewers-signify
148+
# team is empty and pullapprove seems to mis-handle that badly and treats
149+
# _all_ reviewers as being in this group.
150+
#
151+
# See https://github.com/dropseed/pullapprove/issues/71
152+
#
153+
# shared-reviewers-signify:
154+
# type: optional
155+
# conditions:
156+
# - files.include('*')
157+
# reviewers:
158+
# teams: [reviewers-signify]
159+
# reviews:
160+
# request: 10
155161
shared-reviewers-silabs:
156162
type: optional
157163
conditions:

0 commit comments

Comments
 (0)