Skip to content

Commit 1494346

Browse files
hicklinrestyled-commits
authored andcommitted
Update following change in the support for the StartUpMode attribute for the RVC device type (#29862)
* Removed the StartUpMode attribute from the RVC ModeBase clusters in chef's RVC device. * Reverted the changes made in PR 29248 following the spec change in PR 7576. * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 1228ebc commit 1494346

7 files changed

+9
-63
lines changed

examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter

-4
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,6 @@ server cluster RvcRunMode = 84 {
10401040

10411041
readonly attribute ModeOptionStruct supportedModes[] = 0;
10421042
readonly attribute int8u currentMode = 1;
1043-
attribute nullable int8u startUpMode = 2;
10441043
attribute nullable int8u onMode = 3;
10451044
readonly attribute command_id generatedCommandList[] = 65528;
10461045
readonly attribute command_id acceptedCommandList[] = 65529;
@@ -1090,7 +1089,6 @@ server cluster RvcCleanMode = 85 {
10901089

10911090
readonly attribute ModeOptionStruct supportedModes[] = 0;
10921091
readonly attribute int8u currentMode = 1;
1093-
attribute nullable int8u startUpMode = 2;
10941092
attribute nullable int8u onMode = 3;
10951093
readonly attribute command_id generatedCommandList[] = 65528;
10961094
readonly attribute command_id acceptedCommandList[] = 65529;
@@ -1426,7 +1424,6 @@ endpoint 1 {
14261424
server cluster RvcRunMode {
14271425
callback attribute supportedModes default = 0;
14281426
callback attribute currentMode default = 0;
1429-
callback attribute startUpMode default = 0;
14301427
callback attribute onMode default = 0;
14311428
callback attribute generatedCommandList;
14321429
callback attribute acceptedCommandList;
@@ -1442,7 +1439,6 @@ endpoint 1 {
14421439
server cluster RvcCleanMode {
14431440
callback attribute supportedModes default = 0;
14441441
callback attribute currentMode default = 0;
1445-
callback attribute startUpMode default = 0;
14461442
callback attribute onMode default = 0;
14471443
callback attribute generatedCommandList;
14481444
callback attribute acceptedCommandList;

examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap

+3-33
Original file line numberDiff line numberDiff line change
@@ -2266,6 +2266,7 @@
22662266
"define": "SCENES_CLUSTER",
22672267
"side": "server",
22682268
"enabled": 1,
2269+
"apiMaturity": "provisional",
22692270
"commands": [
22702271
{
22712272
"name": "AddScene",
@@ -2811,22 +2812,6 @@
28112812
"maxInterval": 65534,
28122813
"reportableChange": 0
28132814
},
2814-
{
2815-
"name": "StartUpMode",
2816-
"code": 2,
2817-
"mfgCode": null,
2818-
"side": "server",
2819-
"type": "int8u",
2820-
"included": 1,
2821-
"storageOption": "External",
2822-
"singleton": 0,
2823-
"bounded": 0,
2824-
"defaultValue": "0",
2825-
"reportable": 1,
2826-
"minInterval": 1,
2827-
"maxInterval": 65534,
2828-
"reportableChange": 0
2829-
},
28302815
{
28312816
"name": "OnMode",
28322817
"code": 3,
@@ -2999,22 +2984,6 @@
29992984
"maxInterval": 65534,
30002985
"reportableChange": 0
30012986
},
3002-
{
3003-
"name": "StartUpMode",
3004-
"code": 2,
3005-
"mfgCode": null,
3006-
"side": "server",
3007-
"type": "int8u",
3008-
"included": 1,
3009-
"storageOption": "External",
3010-
"singleton": 0,
3011-
"bounded": 0,
3012-
"defaultValue": "0",
3013-
"reportable": 1,
3014-
"minInterval": 1,
3015-
"maxInterval": 65534,
3016-
"reportableChange": 0
3017-
},
30182987
{
30192988
"name": "OnMode",
30202989
"code": 3,
@@ -3391,5 +3360,6 @@
33913360
"endpointId": 1,
33923361
"networkId": 0
33933362
}
3394-
]
3363+
],
3364+
"log": []
33953365
}

examples/rvc-app/README.md

+2-5
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,8 @@ transition to mode 2", set the `RvcRunMode` to 0.
6969

7070
#### TC 3.2
7171

72-
PIXIT: `PIXIT_ENDPOINT:1`
73-
Example command:
74-
`./scripts/tests/run_python_test.py --script src/python_testing/TC_RVCCLEANM_3_2.py --script-args "--storage-path admin_storage.json --PICS examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt --int-arg PIXIT_ENDPOINT:1"`
75-
76-
When asked "Physically power cycle the device", do so.
72+
This is not applicable because this RVC device does not support the
73+
`StartUpMode` attribute.
7774

7875
### RVC Run Mode cluster
7976

examples/rvc-app/rvc-common/pics/RVC Clean Mode Cluster Test Plan.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Draft
6161
<feature>Does the device implement the StartUpMode attribute?</feature>
6262
<reference>89.2.2. Attributes - allclusters.html[pdf]</reference>
6363
<status cond="RVCCLEANM.S">O</status>
64-
<support>true</support>
64+
<support>false</support>
6565
</picsItem>
6666
<picsItem>
6767
<itemNumber>RVCCLEANM.S.A0003</itemNumber>

examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
RVCCLEANM.S=1
22
RVCCLEANM.S.A0000=1
33
RVCCLEANM.S.A0001=1
4-
RVCCLEANM.S.A0002=1
4+
RVCCLEANM.S.A0002=0
55
RVCCLEANM.S.A0003=0
66
RVCCLEANM.S.C01.Tx=1
77
RVCCLEANM.S.C00.Rsp=1

examples/rvc-app/rvc-common/rvc-app.matter

-2
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,6 @@ server cluster RvcCleanMode = 85 {
897897

898898
readonly attribute ModeOptionStruct supportedModes[] = 0;
899899
readonly attribute int8u currentMode = 1;
900-
attribute nullable int8u startUpMode = 2;
901900
readonly attribute command_id generatedCommandList[] = 65528;
902901
readonly attribute command_id acceptedCommandList[] = 65529;
903902
readonly attribute event_id eventList[] = 65530;
@@ -1194,7 +1193,6 @@ endpoint 1 {
11941193
server cluster RvcCleanMode {
11951194
callback attribute supportedModes;
11961195
callback attribute currentMode;
1197-
callback attribute startUpMode;
11981196
callback attribute generatedCommandList;
11991197
callback attribute acceptedCommandList;
12001198
callback attribute eventList;

examples/rvc-app/rvc-common/rvc-app.zap

+2-17
Original file line numberDiff line numberDiff line change
@@ -2439,22 +2439,6 @@
24392439
"maxInterval": 65534,
24402440
"reportableChange": 0
24412441
},
2442-
{
2443-
"name": "StartUpMode",
2444-
"code": 2,
2445-
"mfgCode": null,
2446-
"side": "server",
2447-
"type": "int8u",
2448-
"included": 1,
2449-
"storageOption": "External",
2450-
"singleton": 0,
2451-
"bounded": 0,
2452-
"defaultValue": null,
2453-
"reportable": 1,
2454-
"minInterval": 1,
2455-
"maxInterval": 65534,
2456-
"reportableChange": 0
2457-
},
24582442
{
24592443
"name": "GeneratedCommandList",
24602444
"code": 65528,
@@ -2799,5 +2783,6 @@
27992783
"endpointId": 1,
28002784
"networkId": 0
28012785
}
2802-
]
2786+
],
2787+
"log": []
28032788
}

0 commit comments

Comments
 (0)