Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extra parsing of lane elements which are not in the BPMN spec #2188

Closed
csouchet opened this issue Aug 19, 2022 · 1 comment · Fixed by #2805
Closed

[BUG] Extra parsing of lane elements which are not in the BPMN spec #2188

csouchet opened this issue Aug 19, 2022 · 1 comment · Fixed by #2805
Assignees
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support bug Something isn't working good first issue Good for newcomers hacktoberfest Can be done during the Hacktoberfest
Milestone

Comments

@csouchet
Copy link
Member

csouchet commented Aug 19, 2022

Describe the bug
Currently, in bpmn-visualization@0.26.0, we parse the Lane from a LaneSet and from a Process directly. (See the ProcessConverter https://github.com/process-analytics/bpmn-visualization-js/blob/v0.26.0/src/component/parser/json/converter/ProcessConverter.ts#L95)
However according to the BPMN specification, Lane lane is defined only within a LaneSet.

So, the Lanes are not parsed correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Load a bpmn file with a wrong format (lane directly in process and no laneset)
  2. See no error and the lane is display

Expected behavior
The lane should be not displayed, and we should have a warning/error for the bad format.

Desktop (please complete the following information):

  • Version 0.25.3, 0.26.0

Additional context
If we remove the bad parsing, there is:

  • 7 tests failed in BpmnJsonParser.lane.test.ts
  • no error in the integration tests
  • no error in the e2e tests

BPMN Specification

image

When a `Lane` is defined it is contained within a `LaneSet`, which is contained within a `Process`.

image

ℹ️ For more information: https://www.omg.org/spec/BPMN/2.0.2/PDF

⚠️ Check the contribution guidelines for BPMN support

@csouchet csouchet added bug Something isn't working good first issue Good for newcomers BPMN support Something about the BPMN specification that the lib is already supporting or will support hacktoberfest Can be done during the Hacktoberfest labels Aug 19, 2022
@csouchet csouchet added this to the 0.25.4 milestone Aug 19, 2022
@tbouffard
Copy link
Member

tbouffard commented Aug 19, 2022

I have checked the reference files in the bpmn-miwg-test-suite repository.
All the files that have lanes declare laneset > lane, never declare lanes directly.

If this is in the BPMN specification, this is what it was expected. With this is verification, this is for sure. 🤟🏿

@csouchet csouchet modified the milestones: 0.26.0, 0.26.1 Aug 22, 2022
@tbouffard tbouffard changed the title [BUG] Parse a element on a Process who is not in the BPMN spec [BUG] Extra parsing of lane elements which are not in the BPMN spec Aug 23, 2022
@tbouffard tbouffard modified the milestones: 0.26.1, 0.26.2 Sep 5, 2022
@tbouffard tbouffard modified the milestones: 0.26.2, 0.27.0 Sep 16, 2022
@csouchet csouchet modified the milestones: 0.27.0, 0.27.1 Oct 3, 2022
@tbouffard tbouffard modified the milestones: 0.27.1, 0.27.2 Oct 17, 2022
@csouchet csouchet modified the milestones: 0.27.2, 0.28.1 Oct 28, 2022
@tbouffard tbouffard modified the milestones: 0.28.2, 0.28.3 Nov 28, 2022
@csouchet csouchet modified the milestones: 0.28.3, 0.29.1 Dec 12, 2022
@tbouffard tbouffard modified the milestones: 0.29.1, 0.29.2 Jan 9, 2023
@csouchet csouchet modified the milestones: 0.29.2, 0.29.3 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support bug Something isn't working good first issue Good for newcomers hacktoberfest Can be done during the Hacktoberfest
Projects
No open projects
Archived in project
3 participants