Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar is rendering behind the browser window. #840

Closed
leyanessantiago opened this issue Apr 8, 2019 · 4 comments
Closed

Calendar is rendering behind the browser window. #840

leyanessantiago opened this issue Apr 8, 2019 · 4 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@leyanessantiago
Copy link

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Minimal reproduction of the problem with instructions
Go to PrimeRact documentation in https://www.primefaces.org/primereact/#/calendar and click on Basic, Spanish or Icon example. The calendar is rendering upwards and as it does not fit, it is shown behind the top of the browser. Should render down then.

Environment:
-Ubuntu 18.04.

  • Browser:
    -Chrome 73.0.3683.86 (Official Build) (64-bit)
    -Firefox 66.0.2 (64-bit)
@mjlangan
Copy link

mjlangan commented Apr 8, 2019

This is unfortunately a common problem with these components, and is not unique to just the Calendar. They only seem to check if the component has enough room to render downward, and if not, render upwards, but do not do any check to ensure that the component won't be cut off if it renders upward.

Make your browser window very short in height and many of the components that pop will do it, like TieredMenu

@mertsincan
Copy link
Member

I agree with @mjlangan. Do @leyanessantiago and @mjlangan have any example for these issues? Where should the Calendar's panel be created?

@mjlangan
Copy link

mjlangan commented Apr 22, 2019

Do @leyanessantiago and @mjlangan have any example for these issues?

You mean examples of how to get around it? I've hacked around the behavior with CSS by setting the top myself with !important, but it isn't the most elegant way to solve the problem 😄 The better fix would be in the function these components call to determine their top, and the name of that function escapes me at the moment.

@mertsincan mertsincan self-assigned this Apr 26, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 26, 2019
@mertsincan mertsincan added this to the 3.1.3 milestone Apr 26, 2019
@mertsincan
Copy link
Member

Hi @mjlangan,

Thanks a lot for the response. Fixed now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants