Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dialogs already maximized #1170

Closed
dattebayorob opened this issue Jan 25, 2020 · 5 comments
Closed

Allow Dialogs already maximized #1170

dattebayorob opened this issue Jan 25, 2020 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@dattebayorob
Copy link

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

https://codesandbox.io/s/qjx332qq4

**Current behavior**
Actually, only is possible to maximize the Dialog Component on toogleMaximized event ( When maximizable prop is true )
**Expected behavior**

It would be great if there is a prop to mount component already maximized.

* **PrimeReact version:**
3.1.9
@master117
Copy link
Contributor

Have you tried just toggling it right when it opens?

@dattebayorob
Copy link
Author

But then, I will need user interaction to toogle maximized. It would be great to toogle it auto on prop

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 9, 2020
@cagataycivici cagataycivici added this to the 4.1.0 milestone Mar 9, 2020
@cagataycivici
Copy link
Member

@mertsincan Please implement it for 4.1.0.

@mertsincan
Copy link
Member

mertsincan commented Mar 10, 2020

Please use the following properties on 4.1.0;
maximized?: boolean;
onMaximized?(e: {originalEvent: Event, maximized: boolean}): void;

Exp;

...
this.state = {
   maximized: true
}
...
<Dialog maximized={this.state.maximized} onMaximized={(e) => this.setState({ maximized: e.maximized })} ....>
    ...
</Dialog>

Best Regards,

@dattebayorob
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants