Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Virtual scroll broken #6098

Closed
codyb11989 opened this issue Jul 18, 2018 · 4 comments
Closed

Table: Virtual scroll broken #6098

codyb11989 opened this issue Jul 18, 2018 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@codyb11989
Copy link

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Virtual Scroll changes data but the rows stay at the top of the grid

Expected behavior
Virtual scroll loads appropriate data in the appropriate location

Minimal reproduction of the problem with instructions
Go to the demo site and the issue is visible there
https://www.primefaces.org/primeng/#/table/scroll

Please tell us about your environment:

  • PrimeNG version: 6.0.1
@damatri
Copy link

damatri commented Jul 23, 2018

woahh I was trying to get virtual scroll to work, and it took me so long to figure out the problem was not with my code.

Lazyloading is working correctly but as said the rows are not shown within the view, making virtual scroll unusable

@codyb11989
Copy link
Author

codyb11989 commented Jul 23, 2018

https://github.com/primefaces/primeng/blob/master/src/app/components/table/table.ts#L1768

This should be giving the grid a class of ui-table-virtual-table which would make the table position absolute but this class is not getting added.

I even tried adding position: absolute to tableStyleClass and tableStyle with no luck

@damatri
Copy link

damatri commented Jul 24, 2018

ah you are right! It was as simple as that. When you add:

.ui-table-scrollable-body-table{
  position:absolute;
}

it seems to work. It is a nice quickfix I guess.

@wolves
Copy link

wolves commented Jul 26, 2018

I have created a PR to fix this - #6163

@cagataycivici cagataycivici self-assigned this Jul 26, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 26, 2018
@cagataycivici cagataycivici added this to the 6.0.2 milestone Jul 26, 2018
@cagataycivici cagataycivici changed the title Table: Virtual scroll broken in 6.0.0 Table: Virtual scroll broken Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants