Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar time picking doesn't work with range or multiple selection #4705

Closed
akorchev opened this issue Dec 21, 2017 · 3 comments
Closed

Calendar time picking doesn't work with range or multiple selection #4705

akorchev opened this issue Dec 21, 2017 · 3 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@akorchev
Copy link
Contributor

There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

http://plnkr.co/edit/IPO9mNnEnWcXGYusgBtG?p=preview

Current behavior

The calendar component doesn't support multiple or range selection and showTime=true. When the user tries to select the time there is a JS error because the time handling code can't handle the case when this.value is array.
Expected behavior

The calendar should support time picking in multiple and range selection.
Minimal reproduction of the problem with instructions

<p-calendar selectionMode="range" [showTime]="true"></p-calendar>
<p-calendar selectionMode="multiple" [showTime]="true"></p-calendar>

Steps to reproduce

  1. Make sure selectionMode is set to either range or multiple. Set showTime to true.
  2. Open the calendar and click on a day of the month.
  3. Try to change the time.
  4. The browser will reload the current page and a JS error will be logged in the developer tools.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X
  • PrimeNG version: 2.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@cagataycivici
Copy link
Member

As documented, this is not supported at the moment.

@akorchev
Copy link
Contributor Author

Sorry, didn't find it in the docs. How about #4706? It kind of works and at least there is no runtime exception.

@cagataycivici cagataycivici self-assigned this Jan 22, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 22, 2018
@cagataycivici cagataycivici added this to the 5.2.0-RC2 milestone Jan 22, 2018
@cagataycivici
Copy link
Member

PR merged, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants