Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataList/DataGrid paginator is displayed when it should not be #4655

Closed
CigureanuAlexandru opened this issue Dec 12, 2017 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@CigureanuAlexandru
Copy link

CigureanuAlexandru commented Dec 12, 2017

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
DataList component, when property [paginator] is set to false and [paginatorPosition]='both' remains displayed

Expected behavior
should be hidden

Minimal reproduction of the problem with instructions

  1. declare a 'p-dataList'
  2. set [paginator]=false;
  3. [paginatorPosition]='both'

Where exactly if fails
DataList Component;
Lines:
TopPaginator: *ngIf="paginator && paginatorPosition!='bottom' || paginatorPosition =='both'"
BottomPaginator *ngIf="paginator && paginatorPosition!='top' || paginatorPosition =='both'"
should be
TopPaginator: *ngIf="paginator && (paginatorPosition!='bottom' || paginatorPosition =='both')"
BottomPaginator *ngIf="paginator && (paginatorPosition!='top' || paginatorPosition =='both')"

  • Angular version:
    5.0.0

  • PrimeNG version:
    5.0.2

  • Browser:
    all

  • Language:
    all

@cagataycivici cagataycivici self-assigned this Dec 19, 2017
@cagataycivici cagataycivici added confirmed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Dec 19, 2017
@cagataycivici cagataycivici added this to the 5.1.0-RC1 milestone Dec 19, 2017
@cagataycivici cagataycivici changed the title DataList paginator(top and bottom) are visible even if the paginator is set to be displayed false DataList/DataGrid paginator is displayed when it should not be Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants