Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal span of file upload component remains disabled #4293

Closed
VDubber opened this issue Oct 26, 2017 · 0 comments
Closed

Internal span of file upload component remains disabled #4293

VDubber opened this issue Oct 26, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@VDubber
Copy link

VDubber commented Oct 26, 2017

[X ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/wkcf4RCj03ecMZJfIZ7V?p=preview

Current behavior
When the input attribute disabled is set to false, a internal span remains disabled.

<span class="ui-fileupload-choose ui-button ui-widget ui-state-default ui-corner-all ui-button-text-icon-left" icon="fa-plus" pbutton="" ng-reflect-klass="ui-fileupload-choose" ng-reflect-ng-class="[object Object]" ng-reflect-label="Choose" ng-reflect-icon="fa-plus"
          disabled="false"> 
       ...
</span>

Expected behavior
Internal span does not have disabled attribute applied when component input disabled attribute is false.

Minimal reproduction of the problem with instructions
Create a fileUpload component with [disabled]="false"
DOM indicates that the span is disabled.
By w3c standards, the presence of the disabled attribute is what actually disables the element.

What is the motivation / use case for changing the behavior?
Styles meant to be applied to disabled elements are misapplied.

@cagataycivici cagataycivici self-assigned this Nov 6, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 6, 2017
@cagataycivici cagataycivici added this to the 4.3.1 milestone Nov 6, 2017
@cagataycivici cagataycivici removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants