Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouterLinkActive in tabMenu not applied to the li element. #4081

Closed
ln-e opened this issue Oct 2, 2017 · 0 comments
Closed

RouterLinkActive in tabMenu not applied to the li element. #4081

ln-e opened this issue Oct 2, 2017 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ln-e
Copy link

ln-e commented Oct 2, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://embed.plnkr.co/lDZAZniVKAdDB3n9PRF2/
Click goto B and you can see that first <li> still has ui-state-active class.

Current behavior
When using tabMenu activeItem add active class to the <li> element. But routerLinkActive add active class to the <a> element.

Expected behavior
RouterLinkActive directive set active class to the <li> element as well.

Minimal reproduction of the problem with instructions

  • Angular version: 4.4.3

  • PrimeNG version: 4.2.1

  • Browser: all

@cagataycivici cagataycivici self-assigned this Oct 4, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 4, 2017
@cagataycivici cagataycivici added this to the 4.2.2 milestone Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants