Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import css from install instructions #464

Closed
mariusa opened this issue Aug 11, 2021 · 2 comments
Closed

Add missing import css from install instructions #464

mariusa opened this issue Aug 11, 2021 · 2 comments
Assignees
@onursenture @tugcekucukoglu
Labels
enhancement New feature or request
Milestone
5.0.0

Comments

@mariusa
Copy link

mariusa commented Aug 11, 2021

Please add

import 'primeicons/primeicons.css'

to install instructions at https://www.primefaces.org/primevue/showcase/#/icons
@onursenture onursenture self-assigned this Oct 21, 2021
@onursenture onursenture added the help wanted Extra attention is needed label Oct 21, 2021
@Beyarz
Copy link

Beyarz commented Oct 26, 2021

Shouldn't it be @import 'primeicons/primeicons.css';?

@onursenture onursenture added this to the 5.0.0 milestone Oct 26, 2021
@tugcekucukoglu
Copy link
Member

It has been added to the documentation fbb07ca.

Thanks,

@onursenture onursenture changed the title missing import css from install instructions Add missing import css from install instructions Oct 27, 2021
@onursenture onursenture added enhancement New feature or request and removed help wanted Extra attention is needed labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onursenture onursenture

@tugcekucukoglu tugcekucukoglu

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@onursenture @mariusa @Beyarz @tugcekucukoglu