Spectator list element not saving the Text Colour

[bencie]

Type

Cosmetic

Bug description

Edit a skin's layout, and add a SpectatorList if there's none on the skin. Change the Text Colour, and then retry a map, switch skins, or reload skin. The text colour is reverted back to default.

Screenshots or videos

speclistbug.mp4

Version

2025-306.0-lazer

Logs

compressed-logs.zip

[zihadmahiuddin]

Looks like it's caused by this, not sure why it's being done here and then the opposite is being done here.
I think the one in updateAppearance is enough, and removing the other one does seem to fix the issue for me.

[Joehuu]

@zihadmahiuddin presumably to set the default to:

osu/osu.Game/Screens/Play/HUD/SpectatorList.cs

Line 74 in 4344e08

Colour = colours.Blue0,

but it should be set here:

osu/osu.Game/Screens/Play/HUD/SpectatorList.cs

Line 38 in 4344e08

public BindableColour4 HeaderColour { get; } = new BindableColour4(Colour4.White);

But Blue0 is not static and has to be hardcoded like ArgonWedgePiece (copies Blue1):

osu/osu.Game/Screens/Play/HUD/ArgonWedgePiece.cs

Line 26 in 4c2ebdb

public BindableColour4 AccentColour { get; } = new BindableColour4(Color4Extensions.FromHex("#66CCFF"));

The question is hardcoding again or make those colors static.

[peppy]

I don't know why the header text is customisable here as "text colour". No other argon headers are customisable. I think I'll just remove it for now (because it's implemented weirdly in the first place).