Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiai sound plays in main menu despite star fountains being disabled #32257

Closed
RotusMaximus opened this issue Mar 6, 2025 · 5 comments
Closed

Comments

@RotusMaximus
Copy link

RotusMaximus commented Mar 6, 2025

Type

Game behaviour

Bug description

When playing music in the main menu, the new kiai sound effect introduced in #32162 plays despite the "star fountain" option being disabled. It is not played in song select.

This issue does not appear on initial start up, but once you go back to the main menu once you have been there.

Steps to reproduce:

  1. Start the game; enter song select with star fountains disabled
  2. Go back to the main menu and play any song
  3. At the kiai timings in the song the sound effect will be played

See attached video for an example. First example is how the sound effect plays in the main menu, second example in the video shows that the issue disappears once you are in song select.

Screenshots or videos

kiaiissue.mp4

Version

2025.306.0

Logs

compressed-logs.zip

@Joehuu
Copy link
Member

Joehuu commented Mar 6, 2025

The setting is in gameplay -> general section, so that's intentional. And main menu has star fountains, while song select does not (probably because your skin 1x1's the stars, it doesn't show in main menu).

Closing as intentional, but you can make a discussion to propose the star fountains setting apply everywhere (or another separate setting) or add a condition if the image is 1x1 (but that's hidden behavior).

@Joehuu Joehuu closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2025
@RotusMaximus
Copy link
Author

The setting is in gameplay -> general section, so that's intentional. And main menu has star fountains, while song select does not (probably because your skin 1x1's the stars, it doesn't show in main menu).

You are correct about that, I did not think of this. Can confirm this behaviour. Also, Song select doesn't have any kiai sounds regardless of the star fountain setting.

Closing as intentional, but you can make a discussion to propose the star fountains setting apply everywhere (or another separate setting) or add a condition if the image is 1x1 (but that's hidden behavior).

Fair enough I suppose, I will likely go forward with opening a discussion as in the current state it is not possible to disable this effect in the main menu, which makes listening to my osu library quite annoying. A separate setting under the Audio section to just disable the sound would be nice, using the image size condition (as you pointed yourself) doesn't seem ideal as it's not obvious behaviour.

@Strahlemann-lab
Copy link

Strahlemann-lab commented Mar 6, 2025

same, please let me disable this sound anywhere.

@Joehuu
Copy link
Member

Joehuu commented Mar 6, 2025

Another way is this: #32258

Probably upvote that if you agree or propose something else by commenting there.

@RotusMaximus
Copy link
Author

Another way is this: #32258

Probably upvote that if you agree or propose something else by commenting there.

Noticed that one as well! Upvoted, as I think this is a great idea, however I felt like a "disable toggle" was different enough to warrant it's own discussion which I've started here: #32261. Happy to close my discussion in favor of #32258 if people feel it's too similar though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants