EZ/HR/TP mods don't change stats color inside mod select overlay

[Gabixel]

Type

Cosmetic

Bug description

From my testing, the values don't change color with Easy, Hard Rock and Target Practice

Screenshots or videos

It does change color, however, under the carousel wedge:

Other mods like Half Time and Double Time seem to update the color fine:

Version

2024.1224.1

Logs

n/a

[bdach]

The way this is currently implemented is such that colours only get used on the mod select screen if there are rate-changing mods active that change the "effective" value of one of these difficulty parameters. HR has nothing to do with rate change which is why this isn't highlighted.

That said this is all over the place because the bars under the wedge show the "not effective" values. Dunno. Needs some executive call on how this should work. Obviously the goal here is parity between the two displays, but which way it should be done is disputable. I'd say we want to show the "effective" values everywhere but always use red/green when the values change from base, not only for rate-change induced differences.

@ppy/team-client would appreciate opinions

[peppy]

My personal opinion is it should show when the values change at all, regardless of whether the changes are "effective" or not.

[zihadmahiuddin]

Is that decision final yet (i.e. match the mod select values and colors with the wedge ones)? If so then I'll create a PR for it.

[peppy]

You can attempt it if you'd like.