Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regressions reported since SSBO implementation #24751

Closed
peppy opened this issue Sep 8, 2023 · 4 comments · Fixed by #24805
Closed

Performance regressions reported since SSBO implementation #24751

peppy opened this issue Sep 8, 2023 · 4 comments · Fixed by #24805
Assignees
@smoogipoo
Labels
osu!framework issue Can't resolve this without changes to osu!framework. priority:0 Showstopper. Critical to the next release. type:performance

Comments

@peppy
Copy link
Member

peppy commented Sep 8, 2023

I've experienced corruption and performance regressions on macOS (M2 / Metal) when opening the wiki to the "BanchoBot" article.

Graphical corruption:

2023-09-08_01 07 502x

Weird performance including system wide degradataion:

2023-09-08_01.13.22.mp4
@peppy peppy added priority:0 Showstopper. Critical to the next release. type:performance osu!framework issue Can't resolve this without changes to osu!framework. labels Sep 8, 2023
@peppy
Copy link
Member Author

peppy commented Sep 8, 2023

Also android users have reported performance issues.

@smoogipoo
Copy link
Contributor

Unfortunately I can't repro this on my M1. If anyone is able to reliably reproduce this after multiple restarts of the game, try this o!f branch: https://github.com/smoogipoo/osu-framework/tree/attempt-fix-ssbo

@peppy
Copy link
Member Author

peppy commented Sep 8, 2023

Some more reports of performance degradation we should follow up on in the future:

https://osu.ppy.sh/comments/2868545
https://osu.ppy.sh/comments/2868506
https://osu.ppy.sh/comments/2868385

all OpenGL, it would seem

@peppy peppy mentioned this issue Sep 8, 2023
Closed
@bdach bdach mentioned this issue Sep 8, 2023
Closed
@netfri25
Copy link

I have the same issue, using Ubuntu linux.
after the update everything became laggy and even scrolling stutters

@smoogipoo smoogipoo mentioned this issue Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smoogipoo smoogipoo

Labels
osu!framework issue Can't resolve this without changes to osu!framework. priority:0 Showstopper. Critical to the next release. type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert masking SSBO changes smoogipoo/osu
3 participants
@peppy @smoogipoo @netfri25