Update asserts

Author: peppy

osu.Game.Rulesets.Osu.Tests/Editor/TestSliderScaling.cs

@@ -102,7 +102,7 @@ public void TestScalingSliderFlat()
 
             for (int i = 0; i < 100; i++)
             {
-                Assert.True(Precision.AlmostEquals(sliderPathPerfect.PositionAt(i / 100.0f), sliderPathBezier.PositionAt(i / 100.0f)));
+                Assert.That(Precision.AlmostEquals(sliderPathPerfect.PositionAt(i / 100.0f), sliderPathBezier.PositionAt(i / 100.0f)));
             }
         }
 
@@ -174,7 +174,7 @@ private void assertMatchesPerfectCircle(SliderPath path)
                 double theta = circularArcProperties.ThetaStart + (circularArcProperties.Direction * progress * circularArcProperties.ThetaRange);
                 Vector2 vector = new Vector2((float)Math.Cos(theta), (float)Math.Sin(theta)) * circularArcProperties.Radius;
 
-                Assert.True(Precision.AlmostEquals(circularArcProperties.Centre + vector, path.PositionAt(progress), 0.01f),
+                Assert.That(Precision.AlmostEquals(circularArcProperties.Centre + vector, path.PositionAt(progress), 0.01f),
                     "A perfect circle with points " + string.Join(", ", path.ControlPoints.Select(x => x.Position)) + " and radius" + circularArcProperties.Radius + "from SliderPath does not almost equal a theoretical perfect circle with " + subpoints + " subpoints"
                     + ": " + (circularArcProperties.Centre + vector) + " - " + path.PositionAt(progress)
                     + " = " + (circularArcProperties.Centre + vector - path.PositionAt(progress))

osu.Game.Rulesets.Osu.Tests/StackingTest.cs

@@ -31,7 +31,7 @@ public void TestStacking()
 
                 // The last hitobject triggers the stacking
                 for (int i = 0; i < objects.Count - 1; i++)
-                    Assert.AreEqual(0, ((OsuHitObject)objects[i]).StackHeight);
+                    Assert.That(((OsuHitObject)objects[i]).StackHeight, Is.Zero);
             }
         }
 

osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs

@@ -133,7 +133,7 @@ private ConvertResult convert(string name, Mod[] mods)
 
                 string afterConversion = beatmap.Serialize();
 
-                Assert.AreEqual(beforeConversion, afterConversion, "Conversion altered original beatmap");
+                Assert.That(afterConversion, Is.EqualTo(beforeConversion));
 
                 return new ConvertResult
                 {

osu.Game/Tests/Beatmaps/LegacyModConversionTest.cs

@@ -23,11 +23,11 @@ protected void TestFromLegacy(LegacyMods legacyMods, Type[] expectedMods)
         {
             var ruleset = CreateRuleset();
             var mods = ruleset.ConvertFromLegacyMods(legacyMods).ToList();
-            Assert.AreEqual(expectedMods.Length, mods.Count);
+            Assert.That(mods.Count, Is.EqualTo(expectedMods.Length));
 
             foreach (var modType in expectedMods)
             {
-                Assert.IsNotNull(mods.SingleOrDefault(mod => mod.GetType() == modType));
+                Assert.That(mods.SingleOrDefault(mod => mod.GetType() == modType), Is.Not.Null);
             }
         }
 
@@ -38,7 +38,7 @@ protected void TestToLegacy(LegacyMods expectedLegacyMods, Type[] providedModTyp
                                       .Where(mod => providedModTypes.Contains(mod.GetType()))
                                       .ToArray();
             var actualLegacyMods = ruleset.ConvertToLegacyMods(modInstances);
-            Assert.AreEqual(expectedLegacyMods, actualLegacyMods);
+            Assert.That(actualLegacyMods, Is.EqualTo(expectedLegacyMods));
         }
     }
 }