Merge pull request #32299 from smoogipoo/fix-invalid-password-message

Fix error message on invalid room password

Author: peppy

osu.Game/Online/Multiplayer/InvalidPasswordException.cs

@@ -9,5 +9,9 @@ namespace osu.Game.Online.Multiplayer
     [Serializable]
     public class InvalidPasswordException : HubException
     {
+        public InvalidPasswordException()
+            : base("Invalid password")
+        {
+        }
     }
 }

osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs

@@ -84,12 +84,17 @@ protected override void JoinInternal(Room room, string? password, Action<Room> o
                     onSuccess(room);
                 else
                 {
-                    const string message = "Failed to join multiplayer room.";
-
-                    if (result.Exception != null)
-                        Logger.Error(result.Exception, message);
-
-                    onFailure.Invoke(result.Exception?.AsSingular().Message ?? message);
+                    Exception? exception = result.Exception?.AsSingular();
+
+                    if (exception?.GetHubExceptionMessage() is string message)
+                        onFailure(message);
+                    else
+                    {
+                        const string generic_failure_message = "Failed to join multiplayer room.";
+                        if (result.Exception != null)
+                            Logger.Error(result.Exception, generic_failure_message);
+                        onFailure(generic_failure_message);
+                    }
                 }
             });
         }