Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Pinch to zoom #319

Merged
merged 2 commits into from
May 15, 2024
Merged

Feature/Pinch to zoom #319

merged 2 commits into from
May 15, 2024

Conversation

yllfejziu
Copy link
Member

No description provided.

@yllfejziu yllfejziu requested a review from a team May 13, 2024 22:48
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @tonikocjan.

@yllfejziu yllfejziu requested a review from tonikocjan May 14, 2024 14:03
@yllfejziu yllfejziu force-pushed the feature/pinch-to-zoom-modifier branch from 2ebe54d to 7e4a290 Compare May 14, 2024 14:04
@yllfejziu yllfejziu requested a review from borut-t May 14, 2024 14:06
@yllfejziu
Copy link
Member Author

Demo of the feature in povio app:

RPReplay_Final1715694800.MP4

Copy link
Contributor

@nagavcindriqim nagavcindriqim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🙆‍♂️

Copy link
Contributor

@tonikocjan tonikocjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}

@available(iOS 14.0, *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really want to support SwiftUI on iOS 14. Only 15+. Please update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@yllfejziu yllfejziu force-pushed the feature/pinch-to-zoom-modifier branch from 1610fff to 83660af Compare May 15, 2024 08:13
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@yllfejziu yllfejziu merged commit 5f333ee into develop May 15, 2024
2 checks passed
@yllfejziu yllfejziu deleted the feature/pinch-to-zoom-modifier branch May 15, 2024 08:31
borut-t pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants