Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Implement tappable SwiftUI Text that redirects to link #294

Merged
merged 1 commit into from
May 14, 2024

Conversation

yllfejziu
Copy link
Member

No description provided.

@yllfejziu yllfejziu requested a review from a team October 27, 2023 12:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this test in the Core package?
Maybe we can add this component to the Storybook demo project and add UI tests there instead. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's omit it from Core for now.

@yllfejziu yllfejziu force-pushed the feature/implement-redirecting-swiftui-text branch from 01a338a to ee04d17 Compare November 3, 2023 10:40
Copy link
Contributor

@markom-povio markom-povio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yllfejziu yllfejziu force-pushed the feature/implement-redirecting-swiftui-text branch from cf909f0 to 6ebe936 Compare May 14, 2024 12:17
@yllfejziu yllfejziu requested a review from a team May 14, 2024 12:18
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

import SwiftUI

public extension Text {
/// Creates an instance of hypelinked Text using markdown formatting syntac
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "hypelinked".

@yllfejziu yllfejziu force-pushed the feature/implement-redirecting-swiftui-text branch from 6ebe936 to e6f1215 Compare May 14, 2024 13:14
@yllfejziu yllfejziu merged commit 7b1363e into develop May 14, 2024
2 checks passed
@yllfejziu yllfejziu deleted the feature/implement-redirecting-swiftui-text branch May 14, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants