Fixed removal from PartSurebets in exclude_posit and _decrease_marks (#81)

* Fixed removal from PartSurebets in exclude_posit and _decrease_marks

* reverse_enum func added as a common solution for such bugs

* Refactorings after git

Author: Raashi

surebet/__init__.py

@@ -19,3 +19,8 @@ def find_in_iter(iterable, el):
         return iterable[iterable.index(el)]
     except ValueError:
         return None
+
+
+def reverse_enum(iterable):
+    for idx in range(len(iterable) - 1, -1, -1):
+        yield idx, iterable[idx]

surebet/bookmakers.py

@@ -1,6 +1,7 @@
 from time import sleep
 from requests import Session
 
+from surebet import reverse_enum
 from surebet.handling.surebets import *
 from surebet.loading import try_load
 from surebet.parsing import try_parse
@@ -79,11 +80,11 @@ def _decrease_marks(self):
             for sport in book.attrs_dict().values():
                 for event in sport:
                     for part in event.parts:
-                        for surebet in part.surebets:
+                        for idx, surebet in reverse_enum(part.surebets):
                             surebet.dec_mark()
 
                             if surebet.is_mark_empty():
-                                part.surebets.remove(surebet)
+                                del part.surebets[idx]
 
     def _merge_surebets(self, new_surebets) -> int:  # returns amount of newly added surebets
         new_added = 0

surebet/handling/excluding.py

@@ -1,16 +1,16 @@
-from surebet import find_in_iter
+from surebet import find_in_iter, reverse_enum
 from surebet.handling.surebets import Surebets, Surebet
 
 
 def _del_equal(found_obj, posit_obj) -> None:
     for attr, found_iter in found_obj.__dict__.items():
         if isinstance(found_iter, list):
             posit_iter = getattr(posit_obj, attr)
-            for found_el in list(found_iter):
+            for idx, found_el in reverse_enum(found_iter):
                 posit_el = find_in_iter(posit_iter, found_el)
                 if posit_el:
                     if isinstance(found_el, Surebet):
-                        found_iter.remove(found_el)
+                        del found_iter[idx]
                     # object can contain lists that should not be handled by algorithm
                     # e.g. teams is list of strings, srt is primitive type without __dict__ method
                     elif hasattr(found_el, '__dict__'):