feat!: improve ESM/CJS compatibility, drop support for node 12 #5
Conversation
BREAKING CHANGE: Only node 14.13.1 and higher is now supported. BREAKING CHANGE: ESM/CommonJS compatibility is now improved, but may cause new behavior in certain contexts. It should however be more forward-compatible, and allow usage in a wider range of tools and environments. ADDED: Semantic release automation ADDED: Use @sanity/pkg-utils instead of vite directly, for better control of bundling
| - 16 | ||
| - 14 | ||
| - 12 | ||
| platform: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
I've seen us use this pattern in other repos and in practice we have far fewer macos-latest runners available and it frequently results in long wait times when you have multiple PRs on multiple repos that need merging. I recommend following the pattern we use on repos like sanity client instead, where you have exactly one run of macos-latest and windows-latestand have the rest be strictlyubuntu-latest` 🤔
There was a problem hiding this comment.
To be honest, I think it's (almost) pointless to run tests on windows/mac for modules that do not even use node APIs. There's bound to be differences and pitfalls when doing things like command spawning, file system operations and such - but for pure JS modules it's hard to see where it could fail cross-platform.
Running tests on linux is faster (more availability) and also uncovers any incorrectly cased files, which can sometimes happen when authoring on mac but testing on linux.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Only node 14.13.1 and higher is now supported.
BREAKING CHANGE: ESM/CommonJS compatibility is now improved, but may cause new behavior in certain contexts. It should however be more forward-compatible, and allow usage in a wider range of tools and environments.
ADDED: Semantic release automation
ADDED: Use @sanity/pkg-utils instead of vite directly, for better control of bundling