Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate match checks for inherited trait bodies #4628

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

SeanTAllen
Copy link
Member

Due to how default method bodies are implemented, we only want to do match checks within the context of the trait, not in the context of the class that has inherited the method.

Closes #4612

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Feb 21, 2025
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 21, 2025
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4628.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the 4612 branch 7 times, most recently from 5d4f144 to ed24dbc Compare February 23, 2025 19:24
@SeanTAllen SeanTAllen marked this pull request as ready for review February 23, 2025 19:24
@SeanTAllen SeanTAllen requested a review from a team February 23, 2025 19:25
@SeanTAllen SeanTAllen mentioned this pull request Feb 23, 2025
Due to how default method bodies are implemented, we only want to
do match checks within the context of the trait, not in the context
of the class that has inherited the method.

Closes #4612
@SeanTAllen SeanTAllen merged commit 92d75bc into main Feb 25, 2025
27 checks passed
@SeanTAllen SeanTAllen deleted the 4612 branch February 25, 2025 20:59
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 25, 2025
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default methods and match don't play nice together
3 participants