New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Include output address as part of Node object #108

Closed

nodiesBlade opened this issue Apr 4, 2024 · 1 comment · Fixed by #109

Assignees

Labels

Contributor

nodiesBlade commented Apr 4, 2024

https://github.com/pokt-network/pocket-js/blob/main/packages/types/src/index.ts#L177 doesn't include output address. This must've been missed whenever non custodial was activated. The Pocket RPC node returns this metadata, so it should be as simple as:

adding the new field
https://github.com/pokt-network/pocket-js/blob/main/packages/provider/src/json-rpc-provider.ts#L453, parsing and mapping it here.

(Similarly, we can do this for GetNode and GetNodes)

msmania self-assigned this

msmania added the enhancement label

msmania added this to V0 Dashboard

Contributor Author

nodiesBlade commented Apr 4, 2024

Spoke to @msmania and it should keep all fields of the network including rewards delegators as well.

msmania linked a pull request

that will close this issue

Add outputAddress and rewardDelegators to the Node type #109

Merged

msmania closed this as completed in #109

github-project-automation bot moved this to In Progress in V0 Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment