(Feature) POA solidity-flattener instead of Python solidity flattener #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varasev
reviewed
Sep 21, 2018
make_flat.sh
Outdated
| @@ -1,20 +1,20 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| #pip3 install solidity-flattener --no-cache-dir -U | |||
| #pip3 install poa-solidity-flattener --no-cache-dir -U | |||
There was a problem hiding this comment.
Maybe remove these comments at all?
varasev
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the setup of POA governance smart contracts, the proposal is to replace Python solidity flattener with POA solidity-flattener. It has no known vulnerabilities.
What does the simplification include:
npm install)