-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script doesn't work on Windows (without some workaround) #27
Comments
There's no universal solution to this, Windows installations don't all have |
Thanks, that's better. I think you should include something on readme to make Windows users aware of this, since the first time I tried it I simply assumed it was broken and was about to move on before I noticed it was an easy to solve issue. |
How did you got this to work? I am using a portable version of Python. It is in my System PATH. Still the script is not working for me on Windows. |
@bitsper2nd Make a folder in mpv's directory named "script-opts" then place a file called "sponsorblock.conf" inside it, in that file put the directory of python's executable after "python_path=" Ex: |
Thanks for the quick reply. Sadly the script doesn't seem to be working on mpv.net, which is what I am using. |
@bitsper2nd PRs for support on 3rd party frontends are welcome, but as I don't use them myself I won't be putting my own time into it. |
@po5 don't worry about it. I suspected as much. Could be a mpv.net thing or the libmpv version used is older. That said, mpv.net is based on shinchiro's builds. So I am hopeful in that with future updates, more will be compatible. |
@floppyD hey I'm having a bit of trouble setting this up. It is working for you still? also is there a difference if my python is from the windows store? |
Yes. You should use the python from the website, not the store. |
My Windows mpv installation was running fine until some point early this year until it broke, but since I use Voidlinux on my other machines no hurry. So I took some time to fix it today, and finally worked! Lets go to the steps.
|
@bitsper2nd : it does work just fine for me in mpv.net! I don't know if that was always the case, but other than having to change the ...
_ script-message mpv.net show-history #menu: Tools > Show History
...
CTRL+d cycle-values hwdec auto no #menu: Tools > Toggle Hardware Decoding
_ script-message mpv.net show-setup-dialog #menu: Tools > Setup...
g script-binding sponsorblock/set_segment #menu: SponsorBlock > Set Segment Boundaries
G script-binding sponsorblock/submit_segment #menu: SponsorBlock > Submit Segment
h script-binding sponsorblock/upvote_segment #menu: SponsorBlock > Upvote Previous Segment
H script-binding sponsorblock/downvote_segment #menu: SponsorBlock > Downvote Previous Segment
_ script-message mpv.net shell-execute https://mpv.io #menu: Help > Website mpv
_ script-message mpv.net shell-execute https://github.com/stax76/mpv.net #menu: Help > Website mpv.net
_ ignore #menu: Help > -
_ script-message mpv.net shell-execute https://mpv.io/manual/stable/ #menu: Help > Manual mpv
_ script-message mpv.net shell-execute https://github.com/stax76/mpv.net/blob/master/docs/Manual.md #menu: Help > Manual mpv.net
_ ignore #menu: Help > -
_ script-message mpv.net update-check #menu: Help > Check for Updates
_ script-message mpv.net show-about #menu: Help > About mpv.net
_ ignore #menu: -
Esc quit #menu: Exit
Q quit-watch-later #menu: Exit Watch Later
... If you set the bound keys to I did have to unbind something that was already bound to one of the defaults, and I changed the second for good measure just to be safe (and because it made more sense to me on CTRL+d = hwdec, d = deinterlace). h script-message mpv.net show-history #menu: Tools > Show History
Ctrl+h cycle-values hwdec auto no #menu: Tools > Toggle Hardware Decoding |
I have both Python 2.7.18 x86 and 3.8.7 installed, both set to add to PATH on install (it's opt-in). The issue is that "python" is set to 2.7 by default, and python3 is not set to anything (I reinstalled both to double check).
The solution I found was simply replacing
"python" or "python3"
on line 11 with just"py"
.The text was updated successfully, but these errors were encountered: