Skip to content

Commit eb24429

Browse files
authored
Merge pull request #5885 from szczepax/add_fstab_mount
FEAT: permanent mounting of PMem in ansible script
2 parents 069efd7 + 4d67cd6 commit eb24429

File tree

1 file changed

+25
-5
lines changed

1 file changed

+25
-5
lines changed

utils/ansible/configure-pmem.yml

+25-5
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,18 @@
2929
vars:
3030
newRegions: false
3131
testUser: pmdkuser
32+
mountPoint: /mnt/pmem0
3233

3334
tasks:
3435
- name: "Test if ndctl is installed"
3536
shell: which ndctl
3637

38+
- name: "Remove fstab entry if it exist"
39+
ansible.posix.mount:
40+
path: "{{ mountPoint }}"
41+
state: absent_from_fstab
42+
backup: true
43+
3744
- name: "Unmount namespaces if they exist"
3845
shell: sudo umount /dev/pmem* || true
3946

@@ -64,7 +71,6 @@
6471
#!/usr/bin/env bash
6572
DEV_DAX_R=0x0000
6673
FS_DAX_R=0x0001
67-
MOUNT_POINT="/mnt/pmem0"
6874
6975
function check_alignment() {
7076
local size=$1
@@ -118,13 +124,13 @@
118124
119125
pmem_name=$(create_fsdax)
120126
121-
if [ ! -d "${MOUNT_POINT}" ]; then
122-
sudo mkdir ${MOUNT_POINT}
127+
if [ ! -d "{{ mountPoint }}" ]; then
128+
sudo mkdir {{ mountPoint }}
123129
fi
124130
125131
sudo mkfs.ext4 -F /dev/${pmem_name}
126-
sudo mount -o dax /dev/${pmem_name} ${MOUNT_POINT}
127-
sudo chown -R {{ testUser }} ${MOUNT_POINT}
132+
sudo mount -o dax=always /dev/${pmem_name} {{ mountPoint }}
133+
sudo chown -R {{ testUser }} {{ mountPoint }}
128134
129135
sudo chmod 777 /dev/dax* || true
130136
sudo chmod a+rw /sys/bus/nd/devices/region*/deep_flush
@@ -133,3 +139,17 @@
133139
register: script
134140

135141
- debug: var=script
142+
143+
- name: "Get PMEM device name for {{ mountPoint }} mount point"
144+
shell: |
145+
mount | sed -nr "s/^.*(\/dev\/\S+) on \/mnt\/pmem0.*$/\1/p"
146+
register: pmem_name
147+
148+
- name: "Add /etc/fstab entry for PMEM"
149+
ansible.posix.mount:
150+
path: "{{ mountPoint }}"
151+
src: "{{ pmem_name.stdout }}"
152+
fstype: ext4
153+
opts: rw,relatime,dax=always
154+
state: present
155+
backup: true

0 commit comments

Comments
 (0)