Backport string_view for pre-c++17 compilers #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `v8pp::basic_string_view<Char>` template into `utility.hpp` header with minimal required interface and additional `.str()` member function for simpler conversion to `std::basic_string<Char>` Added `v8pp::convert<string_view>` specialization and test case for it. Replaced `char const*` to `string_view` parameter for name bindings in `class_`, `module`, `context`, and other places.
Added `std::basic_string` operator cast into `v8pp::basic_string_view` polyfill for compatibility with `std::string_view`
On linux, v8pp failed to compile in it's default configuration defined in the makefile (C++14 mode). When compiling in C++14 mode, `__has_include(<string_view>)` returns true and also the header can be included. However the std::string_view is not defined. This uses the macro `__cpp_lib_string_view` instead to check for `std::string_view` availability. It compiles now in both C++14 and C++17 mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
v8pp::basic_string_Viewminium required implementation.