Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.23.0: Setting zsmooth to false for heatmaps seems to be ignored or isn't working in zsmooth on some OS+Browsers e.g. Safari and iPad/iPhone Chrome #6604

Closed
questionlp opened this issue May 13, 2023 · 8 comments · Fixed by #6605
Labels
bug something broken regression this used to work

Comments

@questionlp
Copy link

questionlp commented May 13, 2023

With version 2.23.0, it seems like the data[type=heatmap] zsmooth property to false does not seem to have any effect in Safari (tested in 16.4.1 on macOS Monterey and macOS Ventura, also Safari for iOS 16.4).

No matter what the value is set to, Safari renders the heatmap as a big blurry mess; while, it is nice and crisp rendered in Firefox and Chrome.

Codepen Example: https://codepen.io/theqlp/pen/Poyayop

The issue seems to be a regression from 2.22.0 and can be replicated by changing the script tag in the codepen from:

<script src="https://cdn.plot.ly/plotly-2.23.0.min.js"></script>

to:

<script src="https://cdn.plot.ly/plotly-2.22.0.min.js"></script>

I have posted screenshots showing the behavior of 2.20.0 and 2.23.0 in macOS Safari, 2.23.0 in Firefox and Chrome, and 2.23.0 in Safari for iOS: https://imgur.com/a/m75ozkP

@alexcjohnson
Copy link
Collaborator

Thanks @questionlp - must be from #6574, cc @lvlte @archmoj

@lvlte
Copy link
Contributor

lvlte commented May 14, 2023

@alexcjohnson yeah.. :/ my bad, I should have precisely warned that I couldn't check how the final image actually looks on Safari (don't own a mac).

@questionlp
Copy link
Author

Something that I noticed while checking out 2.23.0 and with older versions of Plotly.js is that saving the image of a heatmap using the built-in download plot as a PNG file does not include the heatmap image in Safari. Checking back with previous versions, including 2.20.0, the behavior exists there as well. It's included in the PNG download in Firefox and Chrome.

Seems like Safari is doing something really funky for some time.

Screenshot: https://imgur.com/a/c4iCy9n
Live example (v2.20.0): https://graphs.wwdt.me/shows/monthly-aggregate-score-heatmap

@archmoj
Copy link
Contributor

archmoj commented May 15, 2023

It's not only Safari but I also see this happening on iPad and iPhone running Chrome!

@archmoj archmoj added regression this used to work bug something broken labels May 15, 2023
@questionlp
Copy link
Author

@archmoj I think it'll be the same with Firefox and other iOS/iPadOS browsers that are still using WebKit for rendering per limitations set by Apple. Eventually, we're supposed to see other web rendering engines made available so that Chrome and Firefox can use their own native renderers; but, I don't know what the timeframe of that is.

@archmoj archmoj changed the title 2.23.0: Setting zsmooth to false for heatmaps seems to be ignored or isn't working in Safari 2.23.0: Setting zsmooth to false for heatmaps seems to be ignored or isn't working in zsmooth on some OS+Browsers e.g. Safari and iPad/iPhone Chrome May 15, 2023
@lvlte
Copy link
Contributor

lvlte commented May 15, 2023

@questionlp yes it seems the webkit rendering engine is the constant for those impacted browsers.

From what I just saw on Safari/Monterey, the behavior is the same as with IE's -ms-interpolation-mode, it works only with <img>, not svg <image>.

@lvlte
Copy link
Contributor

lvlte commented May 15, 2023

Something that I noticed while checking out 2.23.0 and with older versions of Plotly.js is that saving the image of a heatmap using the built-in download plot as a PNG file does not include the heatmap image in Safari. Checking back with previous versions, including 2.20.0, the behavior exists there as well. It's included in the PNG download in Firefox and Chrome.

It sounds like another bug right ? I mean it deserves a separate issue.

@questionlp
Copy link
Author

@lvlte Yeah, I was going to search to see if it was reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants