Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500k point ScatterGL: unselected points don't fade on second selection #2586

Closed
jonmmease opened this issue Apr 27, 2018 · 6 comments · Fixed by #2593
Closed

500k point ScatterGL: unselected points don't fade on second selection #2586

jonmmease opened this issue Apr 27, 2018 · 6 comments · Fixed by #2593
Assignees
Labels
bug something broken

Comments

@jonmmease
Copy link
Contributor

Overview

When displaing a scattergl trace with a large number of points (> 500k), the second time the selection tool is used the unselected points don't fade into the background.

To reproduce:

  1. Run the following codepen (scattergl with 500k points): https://codepen.io/anon/pen/zjoWpO

  2. Perform lasso selection
    screen shot 2018-04-27 at 12 46 05 pm

Note that unselected points fade into the background as expeccted

  1. Double click to clear selection

  2. Perform lasso selection again:
    screen shot 2018-04-27 at 12 46 19 pm

Note that now there is no contrast between selected and unselected points

Comments

  • This doesn't seem to happen with 10k points
  • plotly.js version: 1.36.1
  • Chrome version: Version 65.0.3325.181 (Official Build) (64-bit)
@etpinard etpinard added the bug something broken label Apr 27, 2018
@etpinard
Copy link
Contributor

@dy any ideas?

@dy dy self-assigned this Apr 27, 2018
@dy
Copy link
Contributor

dy commented Apr 30, 2018

Oh, unfortunately that is regl issue, demanding to insert regl._refresh() here and there. I tried to nail it couple of times, to no success, since it requires some complex shader setup. Btw inserting regl._refresh affects drawing performance ~6 times for a thousand of rendering passes, which might be a case for regl-splom or multitrace plots.

@etpinard
Copy link
Contributor

@dy did you file a bug report to regl about this?

@jonmmease
Copy link
Contributor Author

FWIW I'm not noticing this problem in 1.35.2 (The unselected points keep fading on repeated selections). That version was regl-based as well wasn't it?

I'm also noticing another difference between 1.35.2 and 1.36.1. Take a look at the difference in the initial non-zoomed, non-selected views.

1.35.2
screen shot 2018-04-30 at 3 14 23 pm

1.36.1
screen shot 2018-04-30 at 3 14 01 pm

In 1.36.1 the points look less dense. Is there a chance that not all of the points are being rendered in 1.36.1?

@dy
Copy link
Contributor

dy commented Apr 30, 2018

@etpinard that is really complex shader setup, I am in the process of nailing/issuing the bug.

@alexcjohnson
Copy link
Collaborator

In 1.36.1 the points look less dense. Is there a chance that not all of the points are being rendered in 1.36.1?

Is this #2334 again?

It's pretty bad anyway - check out what happens when you make the x values monotonic https://codepen.io/alexcjohnson/pen/GdWEqp

screen shot 2018-04-30 at 3 41 50 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants