From 6f9a59db21f7bb6e34a8bedd4aaa6980e2c35080 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Fri, 2 Aug 2019 16:57:26 -0400 Subject: [PATCH] return early in closeBoundaries when constraint level have edgepath(s) ... in this case joinAllPaths does enough already to render the constraint contours correctly. --- src/traces/contour/close_boundaries.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/traces/contour/close_boundaries.js b/src/traces/contour/close_boundaries.js index b1fc71dbedc..601d8c24ad2 100644 --- a/src/traces/contour/close_boundaries.js +++ b/src/traces/contour/close_boundaries.js @@ -31,6 +31,9 @@ module.exports = function(pathinfo, contours) { // after convertToConstraints, pathinfo has length=0 pi0.prefixBoundary = false; + // joinAllPaths does enough already when edgepaths are present + if(pi0.edgepaths.length) return; + var na = pi0.x.length; var nb = pi0.y.length; var boundaryMax = -Infinity; @@ -60,7 +63,7 @@ module.exports = function(pathinfo, contours) { break; case '<': if(contoursValue < boundaryMin || - (!pi0.edgepaths.length && pi0.starts.length && contoursValue === boundaryMin)) { + (pi0.starts.length && contoursValue === boundaryMin)) { pi0.prefixBoundary = true; } break; @@ -68,7 +71,7 @@ module.exports = function(pathinfo, contours) { v1 = Math.min(contoursValue[0], contoursValue[1]); v2 = Math.max(contoursValue[0], contoursValue[1]); if(v2 < boundaryMin || v1 > boundaryMax || - (!pi0.edgepaths.length && pi0.starts.length && v2 === boundaryMin)) { + (pi0.starts.length && v2 === boundaryMin)) { pi0.prefixBoundary = true; } break;